[kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11

You can view, comment on, or merge this pull request online at:

  https://github.com/kamailio/kamailio/pull/1150

Commit Summary

  • modules/topoh: added IP lookup functionality for trusted or untrusted destination
  • modules/topoh: changed README
  • utils/kamctl: fixed sql schema for topoh modules

File Changes

Patch Links:


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"modules/topoh: added lookup functionality for destination IP (#1150)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11

What is exactly the purpose of this new functionality? To allow/deny traffic from those IP addresses or for doing/skipping topology hiding?

I am somehow not very pleased with importing a lot of code similar to what permissions does in regards to address matching. I would rather do another approach that might bring more flexibility as well, respectively to run an event route where one can run functions from other modules and set some internal variable in order to control what topoh should do after execution of the event block. This should not be something big in terms of new code, I can do it in the next days if we agree on some concept that fits your needs.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: What is exactly the purpose of this new functionality? To allow/deny traffic from those IP addresses or for doing/skipping topology hiding?\r\n\r\nI am somehow not very pleased with importing a lot of code similar to what permissions does in regards to address matching. I would rather do another approach that might bring more flexibility as well, respectively to run an event route where one can run functions from other modules and set some internal variable in order to control what topoh should do after execution of the event block. This should not be something big in terms of new code, I can do it in the next days if we agree on some concept that fits your needs."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307378423"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Yes, exactly this way, just to exclude or include destination IP for topology hiding.
I am not sure that there is a way to do it via internal flags, because the event socket for SREV_NET_DATA_OUT will be called from retransmission function in the tm module and in this case you don't have sip_msg structure anymore.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: Yes, exactly this way, just to exclude or include destination IP for topology hiding. \r\nI am not sure that there is a way to do it via internal flags, because the event socket for SREV_NET_DATA_OUT will be called from retransmission function in the tm module and in this case you don't have sip_msg structure anymore.\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307379548"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

We have the source code, we can change if something helps substantially -- currently, I see two options that can be controlled via a mod param (or just choose one that it is considered better):

  • give a fake request, like it is done with other event_route blocks (e.g., htable:mod-init) -- this way should be very fast
  • parse the outgoing buffer -- might be slightly slower, as it will parse even when not doing topoh


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: We have the source code, we can change if something helps substantially -- currently, I see two options that can be controlled via a mod param (or just choose one that it is considered better):\r\n\r\n * give a fake request, like it is done with other event_route blocks (e.g., htable:mod-init) -- this way should be very fast\r\n * parse the outgoing buffer -- might be slightly slower, as it will parse even when not doing topoh"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307381336"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

so, from topoh we can call topoh-route in kamailio.cfg , there we can use allow_address from the permissions module and base on the result we can reject and accept topoh request. Should we just send empty sip_msg structure there ? Just to avoid sip message parsing in case the request will be rejected ?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: so, from topoh we can call topoh-route in kamailio.cfg , there we can use allow_address from the permissions module and base on the result we can reject and accept topoh request. Should we just send empty sip_msg structure there ? Just to avoid sip message parsing in case the request will be rejected ?"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307382832"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Giving a fake request is very fast, like done at:

It is no parsing apart of the first time. This way is safe, because some functions need the msg structure.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: Giving a fake request is very fast, like done at:\r\n\r\n * https://github.com/kamailio/kamailio/blob/master/src/modules/htable/htable.c#L268\r\n\r\nIt is no parsing apart of the first time. This way is safe, because some functions need the msg structure."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307391182"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

ok. agree.. this way will be more effective and flexible. Should I do or you wanna ? ;-)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: ok. agree.. this way will be more effective and flexible. Should I do or you wanna ? ;-)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-307392619"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

I did an implementation to execute an event_route before the topoh processing for messages to be sent out. Documentation will follow soon, meanwhile you can see the comments of the commit f7d1d23 . Basically, $sndto(ip) should point to the ip address of the destination and calling drop should skip topoh processing. I did no test with the new version, so feedback and improvements are welcome.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: I did an implementation to execute an event_route before the topoh processing for messages to be sent out. Documentation will follow soon, meanwhile you can see the comments of the commit \tf7d1d23 . Basically, $sndto(ip) should point to the ip address of the destination and calling `drop` should skip topoh processing. I did no test with the new version, so feedback and improvements are welcome."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-308633341"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Can this be used for topos as well as topoh?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@amessina in #1150: Can this be used for topos as well as topoh?"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309004565"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Thank you @miconda , unfortunately there is bug that I couldnt catch.

6 days ago I have implemented same way in my repository:

adubovikov/kamailio@ae15a71

but your and my patches makes same results:

/usr/sbin/kamailio[1260]: ERROR: sl [sl_funcs.c:362]: sl_reply_error(): stateless error reply used: I'm terribly sorry, server error occurred (6/SL)
this is after execution of event route. I have tested/removed some code and found that this happens once you call " fmsg = faked_msg_next();"

also in your patch:

f7d1d23#diff-81d708cd01d1642b044346221062c4dbR522

should be:
if(_th_eventrt_outgoing<0 && keng==NULL) {

any suggestions got to avoid this SL error ?

Wbr,
Alexandr


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: Thank you @miconda , unfortunately there is bug that I couldnt catch.\r\n\r\n6 days ago I have implemented same way in my repository:\r\n\r\nhttps://github.com/adubovikov/kamailio/commit/ae15a717e9a5849b4ac295c5864cd6e9b198b6d1\r\n\r\nbut your and my patches makes same results:\r\n\r\n/usr/sbin/kamailio[1260]: ERROR: sl [sl_funcs.c:362]: sl_reply_error(): stateless error reply used: I'm terribly sorry, server error occurred (6/SL)\r\nthis is after execution of event route. I have tested/removed some code and found that this happens once you call \" fmsg = faked_msg_next();\"\r\n\r\nalso in your patch:\r\n\r\nhttps://github.com/kamailio/kamailio/commit/f7d1d234a42198fc10e40c33e92cff5e8fc1af8e#diff-81d708cd01d1642b044346221062c4dbR522\r\n\r\nshould be:\r\nif(_th_eventrt_outgoing\u003c0 **\u0026\u0026** keng==NULL) {\r\n\r\nany suggestions got to avoid this SL error ?\r\n\r\nWbr,\r\nAlexandr\r\n\r\n\r\n\r\n\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309368057"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Indeed, that condition should be with &&.

Is the next fake msg null, or what is failing there? Can you see what is the return code for t_relay? I guess the slow error is because of sl_send_error () in kamaulio.cfg. I am traveling, no much testing that I can do.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: Indeed, that condition should be with \u0026\u0026.\n\nIs the next fake msg null, or what is failing there? Can you see what is the return code for t_relay? I guess the slow error is because of sl_send_error () in kamaulio.cfg. I am traveling, no much testing that I can do."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309378578"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

no, the fake msg is not null, but once you call the faked_msg_next(), after you will always get "I'm terribly sorry, server error occurred (6/SL)", even if you didn't execute "run_top_route".

I will check a bit more, but the issue it can be with pointer for re-transmission.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: no, the fake msg is not null, but once you call the faked_msg_next(), after you will always get \"I'm terribly sorry, server error occurred (6/SL)\", even if you didn't execute \"run_top_route\".\r\n\r\nI will check a bit more, but the issue it can be with pointer for re-transmission.\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309379606"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Might have been the execution of clear_branches() inside next faked msg function, which was resetting some global variables. I just pushed a patch in master, can you give it a try again?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: Might have been the execution of clear_branches() inside next faked msg function, which was resetting some global variables. I just pushed a patch in master, can you give it a try again?"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309457952"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

bingo! :-)

now another issue:

/usr/sbin/kamailio[1798]: ERROR: topoh [topoh_mod.c:560]: th_execute_event_route(): exit due to 'drop' in event route
/usr/sbin/kamailio[1798]: : [core/mem/q_malloc.c:469]: qm_free(): BUG: qm_free: bad pointer 0x7fa3461b9000 (out of memory block!) called from core: core/parser/msg_parser.c: reset_new_uri(720) - aborting
CRITICAL: [core/pass_fd.c:277]: receive_fd(): EOF on 16

and I don't have anything in core:

(gdb) bt full
#0 0x00007f69d1059067 in ?? ()
No symbol table info available.
#1 0x00007f69d105a448 in ?? ()
No symbol table info available.
#2 0x0000000000000020 in ?? ()
No symbol table info available.
#3 0x0000000000000000 in ?? ()
No symbol table info available.
(gdb) quit


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: bingo! :-)\r\n\r\nnow another issue:\r\n\r\n /usr/sbin/kamailio[1798]: ERROR: topoh [topoh_mod.c:560]: th_execute_event_route(): exit due to 'drop' in event route\r\n /usr/sbin/kamailio[1798]: : \u003ccore\u003e [core/mem/q_malloc.c:469]: qm_free(): BUG: qm_free: bad pointer 0x7fa3461b9000 (out of memory block!) called from core: core/parser/msg_parser.c: reset_new_uri(720) - aborting\r\nCRITICAL: \u003ccore\u003e [core/pass_fd.c:277]: receive_fd(): EOF on 16\r\n\r\nand I don't have anything in core:\r\n\r\n(gdb) bt full\r\n#0 0x00007f69d1059067 in ?? ()\r\nNo symbol table info available.\r\n#1 0x00007f69d105a448 in ?? ()\r\nNo symbol table info available.\r\n#2 0x0000000000000020 in ?? ()\r\nNo symbol table info available.\r\n#3 0x0000000000000000 in ?? ()\r\nNo symbol table info available.\r\n(gdb) quit\r\n\r\n"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309512126"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

#1155

looks like it has been fixed :-)


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: https://github.com/kamailio/kamailio/pull/1155\r\n\r\nlooks like it has been fixed :-)"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309673679"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

So #1155 is fixing also the introduced bug with bad pointer?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: So #1155 is fixing also the introduced bug with bad pointer?"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309674524"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

yep. It works now! :-) thank you


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@adubovikov in #1150: yep. It works now! :-) thank you"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309675518"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Thanks, closing it then!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1150: Thanks, closing it then!"}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#issuecomment-309676278"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] modules/topoh: added lookup functionality for destination IP (#1150)

Daniel-Constantin Mierla-11
In reply to this post by Daniel-Constantin Mierla-11

Closed #1150.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #1150."}],"action":{"name":"View Pull Request","url":"https://github.com/kamailio/kamailio/pull/1150#event-1130489809"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Loading...