[kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2

Kamailio 5 did not compile on solaris 11 anymore due to a missing ast/endian.h included from app_jsdt/duk_config.h. The solution is:

--- kamailio-5.0.1~/src/modules/app_jsdt/duk_config.h 2017-04-05 15:32:38.000000000 +0000
+++ kamailio-5.0.1/src/modules/app_jsdt/duk_config.h 2017-04-15 09:27:14.335213048 +0000
@@ -607,7 +607,7 @@
#define DUK_USE_DATE_FMT_STRFTIME

#include <sys/types.h>
-#include <ast/endian.h>
+#include <sys/byteorder.h>
#include <sys/param.h>
#include <sys/time.h>
#include <time.h>


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Compile problem+fix on solaris in app_jsdt (#1072)"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2

The file duk_config.h is imported from Duktape project as it is and I would try to avoid diverting from the official version:

We had tuktape v2.0.0 and I just updated to v2.0.2. Can you try with kamailio master branch and see if all ok? I noticed some updates in the code regarding to this and may have it addressed. If all ok, I will backport.

If not, then I would suggest to also report to ducktape project so there it gets fixed as well.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1072: The file `duk_config.h` is imported from Duktape project as it is and I would try to avoid diverting from the official version:\r\n\r\n * https://duktape.org\r\n\r\nWe had tuktape v2.0.0 and I just updated to v2.0.2. Can you try with kamailio master branch and see if all ok? I noticed some updates in the code regarding to this and may have it addressed. If all ok, I will backport.\r\n\r\nIf not, then I would suggest to also report to ducktape project so there it gets fixed as well."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#issuecomment-294910194"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2
In reply to this post by lazedo-2

Any chance to try with v2.0.2 as mentioned above?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1072: Any chance to try with v2.0.2 as mentioned above?"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#issuecomment-297426352"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2
In reply to this post by lazedo-2

Just tried it, same problem. Will need to report it upstream! Not sure whether you need to fix it in your source tree, as solaris is becoming less and less common...

I also checked whether ast/endian.h might be included in a package which I just happen to not have installed, but no, there is no ast/endian.h in the whole of Solaris 11.3. So the #ifdef DUK_F_OLD_SOLARIS must relate to something pre-historic, and the #else to something medieval ;-)

Anyway, thanks for kamailio!


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@celan69 in #1072: Just tried it, same problem. Will need to report it upstream! Not sure whether you need to fix it in your source tree, as solaris is becoming less and less common...\r\n\r\nI also checked whether ast/endian.h might be included in a package which I just happen to not have installed, but no, there is no ast/endian.h in the whole of Solaris 11.3. So the #ifdef DUK_F_OLD_SOLARIS must relate to something pre-historic, and the #else to something medieval ;-)\r\n\r\nAnyway, thanks for kamailio!"}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#issuecomment-298112505"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2
In reply to this post by lazedo-2

Had any time to push to duktape? I would like to import it inside kamailio if there is a fix there.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1072: Had any time to push to duktape? I would like to import it inside kamailio if there is a fix there."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#issuecomment-301570501"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2
In reply to this post by lazedo-2

Closed #1072.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"DESCRIPTION","message":"Closed #1072."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#event-1121333486"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [kamailio/kamailio] Compile problem+fix on solaris in app_jsdt (#1072)

lazedo-2
In reply to this post by lazedo-2

Closing this one, I aso upgraded to duktape 2.1.0 meanwhile.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda in #1072: Closing this one, I aso upgraded to duktape 2.1.0 meanwhile."}],"action":{"name":"View Issue","url":"https://github.com/kamailio/kamailio/issues/1072#issuecomment-308110599"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Loading...