Re: [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)

00Asgaroth00

@miconda Hi Daniel. not sure why but we're getting some crashes under load without this commit.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@lazedo on be46742: @miconda Hi Daniel. not sure why but we're getting some crashes under load without this commit.\r\n"}],"action":{"name":"View Commit","url":"https://github.com/kamailio/kamailio/commit/be46742ebe162a2c48ee5ce27e09497b23b66ea5#commitcomment-22521831"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)

00Asgaroth00

Can you reproduce it on a test system? Do you have a core dump and backtrace? Are there error message related to memory fragments having beginning/tail overwritten?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda on be46742: Can you reproduce it on a test system? Do you have a core dump and backtrace? Are there error message related to memory fragments having beginning/tail overwritten?"}],"action":{"name":"View Commit","url":"https://github.com/kamailio/kamailio/commit/be46742ebe162a2c48ee5ce27e09497b23b66ea5#commitcomment-22524007"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)

Luis Azedo-2

Hi Daniel,


sorry for the buzz, its not related to this commit.

the issue seems to be a race condition with expired keys.

i'll investigate this  and try to consistently recreate it.


Best


From: sr-dev <[hidden email]> on behalf of Daniel-Constantin Mierla <[hidden email]>
Sent: Tuesday, June 13, 2017 10:36:40 PM
To: Kamailio Devel List
Cc: Subscribed
Subject: Re: [sr-dev] [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)
 

Can you reproduce it on a test system? Do you have a core dump and backtrace? Are there error message related to memory fragments having beginning/tail overwritten?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda on be46742: Can you reproduce it on a test system? Do you have a core dump and backtrace? Are there error message related to memory fragments having beginning/tail overwritten?"}],"action":{"name":"View Commit","url":"https://github.com/kamailio/kamailio/commit/be46742ebe162a2c48ee5ce27e09497b23b66ea5#commitcomment-22524007"}}}</script>

_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev
Reply | Threaded
Open this post in threaded view
|

Re: [kamailio/kamailio] htable: fix crash if deleted entry is reused (be46742)

00Asgaroth00
In reply to this post by 00Asgaroth00

No worries, if it crashes there is an issue and I want to discover as soon as possible, I use htable everywhere. It just didn't feel the right place for the issue, but a side effect of something else, so that's why I tried to figure out where, not to have a patch that can hide it a bit better, but not really fixing it.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.

<script type="application/json" data-scope="inboxmarkup">{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/kamailio/kamailio","title":"kamailio/kamailio","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/kamailio/kamailio"}},"updates":{"snippets":[{"icon":"PERSON","message":"@miconda on be46742: No worries, if it crashes there is an issue and I want to discover as soon as possible, I use htable everywhere. It just didn't feel the right place for the issue, but a side effect of something else, so that's why I tried to figure out where, not to have a patch that can hide it a bit better, but not really fixing it."}],"action":{"name":"View Commit","url":"https://github.com/kamailio/kamailio/commit/be46742ebe162a2c48ee5ce27e09497b23b66ea5#commitcomment-22533516"}}}</script>
_______________________________________________
Kamailio (SER) - Development Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-dev