Pull Request or Issue? - coredump in case no contentLengthHdr present in REGISTER

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Pull Request or Issue? - coredump in case no contentLengthHdr present in REGISTER

Valentin Christoph

Hi all,

 

We have identified an IMS related issue, when the “Content-Length” header is missing in REGISTER request.

 

It’s a missing null pointer check in file modules/ims_auth/utils.c

 

We are using Kamailio 4.4.5 for this purpose and we would need a fix in that release.

 

I’m not sure, how to proceed now? Should I just create an “Issue” at GitHub, or is it possible for me to create a “Pull Request” at GitHub (would be less effort for you, I guess).

 

Anyway, the change we did in our local GIT repository, is shown in following picture:

 

 

Thanks,

Christoph




The information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.


_______________________________________________
Kamailio (SER) - Users Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Pull Request or Issue? - coredump in case no contentLengthHdr present in REGISTER

Daniel-Constantin Mierla-6

Hello,

you have to make a pull request via github for master branch first and if all ok, then it can be backported to 5.0 and 4.4 branches.

See first:

  - https://github.com/kamailio/kamailio/blob/master/.github/CONTRIBUTING.md

The commit message format must be done as per the file above in order to merge the pull request smoothly.

Cheers,
Daniel


On 03.08.17 16:38, Valentin Christoph wrote:

Hi all,

 

We have identified an IMS related issue, when the “Content-Length” header is missing in REGISTER request.

 

It’s a missing null pointer check in file modules/ims_auth/utils.c

 

We are using Kamailio 4.4.5 for this purpose and we would need a fix in that release.

 

I’m not sure, how to proceed now? Should I just create an “Issue” at GitHub, or is it possible for me to create a “Pull Request” at GitHub (would be less effort for you, I guess).

 

Anyway, the change we did in our local GIT repository, is shown in following picture:

 

 

Thanks,

Christoph




The information contained in this e-mail message is privileged and confidential and is for the exclusive use of the addressee. The person who receives this message and who is not the addressee, one of his employees or an agent entitled to hand it over to the addressee, is informed that he may not use, disclose or reproduce the contents thereof, and is kindly asked to notify the sender and delete the e-mail immediately.



_______________________________________________
Kamailio (SER) - Users Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users

-- 
Daniel-Constantin Mierla
www.twitter.com/miconda -- www.linkedin.com/in/miconda
Kamailio Advanced Training - www.asipto.com
Kamailio World Conference - www.kamailioworld.com

_______________________________________________
Kamailio (SER) - Users Mailing List
[hidden email]
https://lists.kamailio.org/cgi-bin/mailman/listinfo/sr-users
Loading...